worker/jobs: Simplify and inline enqueue_sync_to_index() fn
#9629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires two queries instead of one, but it significantly simplifies the code, now that our worker system supports automatic deduplication. Once the enqueuing code uses `diesel-async` the performance hit can be mitigated by using pipelining via `try_join!()`.
Turbo87
added
C-internal 🔧
LawnGnome
approved these changes
Oct 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9629 +/- ##
==========================================
- Coverage 88.88% 88.85% -0.04%
==========================================
Files 289 288 -1
Lines 29232 29222 -10
==========================================
- Hits 25982 25964 -18
- Misses 3250 3258 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our background worker system supports automatic deduplication we don't need the
enqueue_sync_to_index()fn anymore. The old fn had the advantage of only needing a single query to enqueue both jobs, but IMHO the additional complexity isn't worth it and withdiesel-asyncsupporting pipelining it should be possible to mitigate the performance impact too.